Skip to content

Adding missing param description to NetworkStream.Write(System.ReadOnlySpan{System.Byte}) #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2019
Merged

Adding missing param description to NetworkStream.Write(System.ReadOnlySpan{System.Byte}) #2897

merged 1 commit into from
Aug 1, 2019

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Jul 31, 2019

After adding documentation for System.Net.Sockets in #2767, we found out that one param went away with no proper description.
This change adds the missing description to it.

@jozkee
Adding missing param description to NetworkStream.Write(System.ReadOn…
4bec9ff 
…lySpan{System.Byte})

After adding documentation for System.Net.Sockets in dotnet#2767, we found out that one param went away with no proper description.
This change adds the missing description to it.
@jozkee jozkee requested a review from karelz as a code owner July 31, 2019 23:53
@jozkee
Copy link
Member Author

jozkee commented Jul 31, 2019

@mairaw @rpetrusha @carlossanlop

@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 1, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 1, 2019
@rpetrusha rpetrusha removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Aug 1, 2019
rpetrusha
rpetrusha approved these changes Aug 1, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; thanks for catching it, @jozkee. I'll merge your PR now.

@rpetrusha rpetrusha merged commit ef58855 into dotnet:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelz karelz Awaiting requested review from karelz

@mairaw mairaw Awaiting requested review from mairaw

@scalablecory scalablecory Awaiting requested review from scalablecory

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jozkee jozkee

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@jozkee @rpetrusha @carlossanlop